Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 Extract schema to dedicated namespace #18858

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

shivekkhurana
Copy link
Contributor

This is an extension to a PR I raised earlier #18696. The last PR didn't have the schema in dedicated namespaces. I have made that distinction now.

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Feb 16, 2024

Jenkins Builds

Click to see older builds (4)
Commit #️⃣ Finished (UTC) Duration Platform Result
7519ed9 #1 2024-02-16 11:36:32 ~52 sec ios 📄log
7519ed9 #1 2024-02-16 11:36:38 ~57 sec android 📄log
7519ed9 #1 2024-02-16 11:36:42 ~1 min android-e2e 📄log
7519ed9 #1 2024-02-16 11:37:15 ~1 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 0068b38 #2 2024-02-19 12:06:24 ~6 min tests 📄log
✔️ 0068b38 #2 2024-02-19 12:07:58 ~7 min ios 📱ipa 📲
✔️ 0068b38 #2 2024-02-19 12:08:54 ~8 min android-e2e 🤖apk 📲
✔️ 0068b38 #2 2024-02-19 12:09:04 ~8 min android 🤖apk 📲
✔️ 824ee93 #4 2024-02-19 13:12:32 ~5 min tests 📄log
✔️ 824ee93 #4 2024-02-19 13:13:50 ~6 min ios 📱ipa 📲
✔️ 824ee93 #4 2024-02-19 13:15:36 ~8 min android-e2e 🤖apk 📲
✔️ 824ee93 #4 2024-02-19 13:15:57 ~8 min android 🤖apk 📲

Copy link
Member

@clauxx clauxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really mind having the schema in the same file with the component. I think we tend to extract them when the schema gets big or there's multiple schema vars, but either way I don't have a preference on this.

src/quo/components/wallet/summary_info/view.cljs Outdated Show resolved Hide resolved
@shivekkhurana shivekkhurana self-assigned this Feb 19, 2024
@shivekkhurana shivekkhurana force-pushed the shivekkhurana/extract-batch-2-to-its-own-ns branch from 67d8ecf to 824ee93 Compare February 19, 2024 13:06
@shivekkhurana shivekkhurana merged commit ed427cf into develop Feb 19, 2024
6 checks passed
@shivekkhurana shivekkhurana deleted the shivekkhurana/extract-batch-2-to-its-own-ns branch February 19, 2024 13:16
ibrkhalil pushed a commit that referenced this pull request Feb 25, 2024
* 🧪 Extract schema to dedicated namespace

* ✏️ Fix syntax errors and dep issue

* 🦞 Follow guidelines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants